fix: tsconfig not found with TS >= 5.3 #2091

edosrecki · 2023-11-23T11:08:55Z

Fixes #2076
Fixes #2090

Fixes 2076

edosrecki · 2023-11-23T12:23:34Z

Added tests as well.

Before fix:

After fix:

karlhorky · 2023-11-24T11:05:08Z

This can also be marked as "Fixes #2090" I think

edosrecki · 2023-11-24T13:19:36Z

@karlhorky I marked it but in my opinion author of that issue should close it as duplicate of #2076.

karlhorky · 2023-11-24T13:23:52Z

author of that issue should close it as duplicate of #2076

Sounds most reasonable, yeah.

But good to have it also here to clean up the other issue, eg. just in case the author is gone now.

fengmk2

LGTM

TypeStrong/ts-node#2091

alyahmedaly · 2023-11-28T09:49:48Z

is there any reason why this PR is not merged?

edosrecki · 2023-11-28T10:16:34Z

Hi @blakeembrey, @cspotcode

could you please take a look at this PR?

TypeStrong/ts-node#2091

fengmk2 · 2023-12-04T05:45:53Z

Can we get the merge and release before Christmas?

johnnyreilly · 2023-12-06T15:42:12Z

I have the ability to merge this PR, but I generally don't work on this and so I'm hesitant to, despite requests:

https://twitter.com/karlhorky/status/1732370956335596025

Is there more context that can be shared?

effektsvk · 2023-12-06T15:57:31Z

@johnnyreilly I debugged the original issue, the problem was that TypeScript introduced a breaking change in the internal API that is used by ts-node. Here is the comment: microsoft/TypeScript#56492 (comment)

(I hope that is what you're looking for 😅)

johnnyreilly · 2023-12-06T16:26:50Z

I'm more wondering why the typical maintainers haven't picked this up - whilst I have the power to hit merge, this isn't a repo I typically work on and I'm looking to understand what the usual maintainers are feeling.

peaceshi · 2023-12-06T16:59:23Z

This issue also makes me confused for several hours.
Why not merged until now?
https://github.com/2ndlab/vscode-extension-packages/blob/72c4812d5638ed967e44397736ef5b50cec5da95/src/tools/tsconfig.json#L12C5-L12C5

torokati44 · 2023-12-07T09:29:01Z

This issue also makes me confused for several hours.
Why not merged until now?

+1

This also blocks ruffle-rs/ruffle#14262.

alumni · 2023-12-07T11:40:18Z

Even if this PR gets merged, we would also need a release.

I'm more wondering why the typical maintainers haven't picked this up - whilst I have the power to hit merge, this isn't a repo I typically work on and I'm looking to understand what the usual maintainers are feeling.

It's open source software, people work on it in their spare time. Maybe they are not even using the latest TS version in their projects, or maybe they don't even work with nodejs anymore. There are a lot of libraries that are like that, e.g. ts-jest is broken since typescript 5.2, typeorm has a ton of pending PRs. I tend not to judge but to have patience :)

hilleer · 2023-12-07T12:02:25Z

Even if this PR gets merged, we would also need a release.

I'm more wondering why the typical maintainers haven't picked this up - whilst I have the power to hit merge, this isn't a repo I typically work on and I'm looking to understand what the usual maintainers are feeling.

It's open source software, people work on it in their spare time. Maybe they are not even using the latest TS version in their projects, or maybe they don't even work with nodejs anymore. There are a lot of libraries that are like that, e.g. ts-jest is broken since typescript 5.2, typeorm has a ton of pending PRs. I tend not to judge but to have patience :)

Should they be considered the typical maintainers then in this case? 🙂

| datasource | package | from | to | | ---------- | ------- | ------ | ------ | | npm | ts-node | 10.9.1 | 10.9.2 | ## [v10.9.2](https://github.com/TypeStrong/ts-node/releases/tag/v10.9.2) **Fixed** - Fixed `tsconfig.json` file not found on latest TypeScript version (TypeStrong/ts-node#2091)

edosrecki mentioned this pull request Nov 23, 2023

tsconfig not found when extends scope with ts-node>10.0 and typescript@>=5.3.0-dev #2076

Closed

fix: tsconfig not found with TS >= 5.3

9be5938

Fixes 2076

edosrecki force-pushed the 2076 branch from 57d186c to 9be5938 Compare November 23, 2023 12:11

karlhorky mentioned this pull request Nov 24, 2023

Cypress fails to start with Typescript ^5.3.2 when using extends in tsconfig.json cypress-io/cypress#28385

Closed

fengmk2 approved these changes Nov 25, 2023

View reviewed changes

fengmk2 added a commit to node-modules/is-type-of that referenced this pull request Nov 25, 2023

deps: use ts 5.2.2

d2b7733

TypeStrong/ts-node#2091

alumni approved these changes Nov 25, 2023

View reviewed changes

This was referenced Nov 26, 2023

chore: avoid TypeScript 5.3 jest-community/eslint-plugin-jest#1473

Merged

chore(deps): update dependency typescript to ~5.4.0 - autoclosed jest-community/eslint-plugin-jest#1474

Closed

haoqunjiang mentioned this pull request Nov 27, 2023

chore(deps): update dependency typescript to ~5.3.0 vuejs/create-vue#391

Merged

1 task

karlhorky added a commit to karlhorky/electron-app-patcher that referenced this pull request Nov 30, 2023

Downgrade to [email protected] until ts-node fixed

b11dfe6

TypeStrong/ts-node#2091

nwalters512 mentioned this pull request Dec 1, 2023

Bump typescript from 5.2.2 to 5.3.2 PrairieLearn/PrairieLearn#9018

Closed

G-Rath mentioned this pull request Dec 3, 2023

chore: use relative path to parent tsconfig.json jest-community/eslint-plugin-jest#1476

Merged

glensc approved these changes Dec 5, 2023

View reviewed changes

erik-slovak mentioned this pull request Dec 6, 2023

chore(deps): update dependency typescript to ^5.3.3 technology-studio/nexus-prisma#132

Merged

1 task

thewilkybarkid mentioned this pull request Dec 6, 2023

Bump typescript from 5.2.2 to 5.3.2 PREreview/prereview.org#1419

Closed

dasunhegoda mentioned this pull request Sep 17, 2024

[Snyk] Upgrade: , esno, jsdoc-to-markdown, ts-node, typedoc OpenSPP/openfn-adaptors#51

Open

WontonSam mentioned this pull request Sep 17, 2024

[Snyk] Upgrade: , , , , , graphql, ts-node, typescript WontonSam/apollo-federation-subgraph-compatibility#519

Open

BitcoinOutput mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: , , aptos, chalk, commander, dotenv, figlet, ts-node, typescript BitcoinOutput/iaptos-nft-random-mint#317

Open

WontonSam mentioned this pull request Sep 19, 2024

[Snyk] Upgrade: , , , , , graphql, ts-node, typescript WontonSam/apollo-federation-subgraph-compatibility#526

Open

Mustafaovais mentioned this pull request Sep 22, 2024

[Snyk] Upgrade: ts-node, typescript, web3-eth-abi Mustafaovais/wormhole#5

Open

BitcoinOutput mentioned this pull request Sep 22, 2024

[Snyk] Upgrade: , , aptos, chalk, commander, dotenv, figlet, ts-node, typescript BitcoinOutput/iaptos-nft-random-mint#321

Open

snyk-io bot mentioned this pull request Sep 23, 2024

[Snyk] Upgrade ts-node from 7.0.1 to 10.9.2 SherfeyInv/token-profile#4

Open

renovate bot mentioned this pull request Sep 28, 2024

chore(deps): update all non-major dependencies nuxt/typescript#625

Open

1 task

dimitropoulos mentioned this pull request Oct 24, 2024

updates jest/ts-jest to latest vercel/turborepo#9155

Merged

9 tasks

bhaskar-allam mentioned this pull request Oct 30, 2024

[Snyk] Upgrade ts-node from 10.9.1 to 10.9.2 bhaskar-allam/cacti#5

Open

HaLaGu1L mentioned this pull request Nov 1, 2024

[Snyk] Upgrade ts-node from 10.7.0 to 10.9.2 HaLaGu1L/wallet-core#9

Open

mainframev mentioned this pull request Nov 8, 2024

chore: migrate to ts 5.3.3 microsoft/fluentui#33235

Open

JhayceFrancis mentioned this pull request Nov 10, 2024

[Snyk] Upgrade ts-node from 9.1.1 to 10.9.2 JhayceFrancis/nativescript-nfc#13

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: tsconfig not found with TS >= 5.3 #2091

fix: tsconfig not found with TS >= 5.3 #2091

edosrecki commented Nov 23, 2023 •

edited

Loading

edosrecki commented Nov 23, 2023

karlhorky commented Nov 24, 2023

edosrecki commented Nov 24, 2023

karlhorky commented Nov 24, 2023 •

edited

Loading

fengmk2 left a comment

alyahmedaly commented Nov 28, 2023

edosrecki commented Nov 28, 2023

fengmk2 commented Dec 4, 2023

johnnyreilly commented Dec 6, 2023

effektsvk commented Dec 6, 2023 •

edited

Loading

johnnyreilly commented Dec 6, 2023

peaceshi commented Dec 6, 2023

torokati44 commented Dec 7, 2023

alumni commented Dec 7, 2023

hilleer commented Dec 7, 2023

fix: tsconfig not found with TS >= 5.3 #2091

fix: tsconfig not found with TS >= 5.3 #2091

Conversation

edosrecki commented Nov 23, 2023 • edited Loading

edosrecki commented Nov 23, 2023

karlhorky commented Nov 24, 2023

edosrecki commented Nov 24, 2023

karlhorky commented Nov 24, 2023 • edited Loading

fengmk2 left a comment

Choose a reason for hiding this comment

alyahmedaly commented Nov 28, 2023

edosrecki commented Nov 28, 2023

fengmk2 commented Dec 4, 2023

johnnyreilly commented Dec 6, 2023

effektsvk commented Dec 6, 2023 • edited Loading

johnnyreilly commented Dec 6, 2023

peaceshi commented Dec 6, 2023

torokati44 commented Dec 7, 2023

alumni commented Dec 7, 2023

hilleer commented Dec 7, 2023

edosrecki commented Nov 23, 2023 •

edited

Loading

karlhorky commented Nov 24, 2023 •

edited

Loading

effektsvk commented Dec 6, 2023 •

edited

Loading